Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump the all-go-mod-patch-and-minor group across 2 directories with 5 updates #3125

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 29, 2024

Bumps the all-go-mod-patch-and-minor group with 3 updates in the / directory: github.com/vmware/govmomi, github.com/onsi/ginkgo/v2 and sigs.k8s.io/kustomize/api.
Bumps the all-go-mod-patch-and-minor group with 2 updates in the /test directory: github.com/vmware/govmomi and github.com/onsi/ginkgo/v2.

Updates github.com/vmware/govmomi from 0.38.0 to 0.39.0

Release notes

Sourced from github.com/vmware/govmomi's releases.

v0.39.0

Release v0.39.0

Release Date: 2024-07-22

🐞 Fix

  • [1bc3a4a4] handle base types by default in mo.LoadObjectContent

💫 API Changes

  • [5c0af375] use CheckTestType in compat and provisioning checkers
  • [2e77836c] add sata controller
  • [bdb034ee] Exporting Unit field in MetricSeries struct for external use (#3494)
  • [78f07c63] Add simulator test for GetVirtualDiskInfoByUUID
  • [2d16e19f] GetVirtualDiskInfoByUUID for getting capacity/size info
  • [29b1bce9] change CoresPerNumaNode to a pointer type
  • [3139de32] Add a method for extending VMDK
  • [6096c0d4] add ResolveLibraryItemStorage

💫 govc (CLI)

  • [04fe4c26] add vm.check commands
  • [976bca3b] add '-spec' flag to vm clone, migrate and create commands
  • [d92015c4] add vm.migrate -net flag

💫 vcsim (Simulator)

  • [eb2e1ea1] add VmCompatibilityChecker and VmProvisioningChecker
  • [a463e543] Add support for DRS automation levels (#3485)
  • [f7a85a81] Re-enable TenantManager

🧹 Chore

  • [590c92b1] Update version.go for v0.39.0
  • [4434e26b] bump go version
  • [d7e27099] fix codeql (#3492) (#3492)
  • [fb6e5977] fix codeql

⚠️ BREAKING

📖 Commits

  • [590c92b1] chore: Update version.go for v0.39.0
  • [5c0af375] api: use CheckTestType in compat and provisioning checkers
  • [2e77836c] api: add sata controller
  • [bdb034ee] api: Exporting Unit field in MetricSeries struct for external use (#3494)
  • [4434e26b] chore: bump go version

... (truncated)

Commits
  • 590c92b chore: Update version.go for v0.39.0
  • 7614742 Merge pull request #3502 from bryanv/bryanv/use-checktesttype-in-check-args
  • f05efc4 Merge pull request #3458 from vmware/api/add-sata-controller
  • 5c0af37 api: use CheckTestType in compat and provisioning checkers
  • 2e77836 api: add sata controller
  • 4ce273c Merge pull request #3500 from dougm/vcsim-vmcheck
  • 441e932 Merge pull request #3497 from aneesurrehman001/feature/export-unit-field
  • bdb034e api: Exporting Unit field in MetricSeries struct for external use
  • 4434e26 chore: bump go version
  • 04fe4c2 govc: add vm.check commands
  • Additional commits viewable in compare view

Updates github.com/onsi/ginkgo/v2 from 2.19.0 to 2.19.1

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.19.1

2.19.1

Fixes

  • update supported platforms for race conditions [63c8c30]
  • [build] Allow custom name for binaries. [ff41e27]

Maintenance

  • bump gomega [76f4e0c]
  • Bump rexml from 3.2.6 to 3.2.8 in /docs (#1417) [b69c00d]
  • Bump golang.org/x/sys from 0.20.0 to 0.21.0 (#1425) [f097741]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.19.1

Fixes

  • update supported platforms for race conditions [63c8c30]
  • [build] Allow custom name for binaries. [ff41e27]

Maintenance

  • bump gomega [76f4e0c]
  • Bump rexml from 3.2.6 to 3.2.8 in /docs (#1417) [b69c00d]
  • Bump golang.org/x/sys from 0.20.0 to 0.21.0 (#1425) [f097741]
Commits

Updates github.com/onsi/gomega from 1.33.1 to 1.34.0

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.34.0

1.34.0

Features

  • Add RoundTripper method to ghttp.Server [c549e0d]

Fixes

  • fix incorrect handling of nil slices in HaveExactElements (fixes #771) [878940c]
  • issue_765 - fixed bug in Hopcroft-Karp algorithm [ebadb67]

Maintenance

  • bump ginkgo [8af2ece]
  • Fix typo in docs [123a071]
  • Bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3 (#756) [0e69083]
  • Bump google.golang.org/protobuf from 1.33.0 to 1.34.1 (#755) [2675796]
  • Bump golang.org/x/net from 0.24.0 to 0.25.0 (#754) [4160c0f]
  • Bump github-pages from 230 to 231 in /docs (#748) [892c303]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.34.0

Features

  • Add RoundTripper method to ghttp.Server [c549e0d]

Fixes

  • fix incorrect handling of nil slices in HaveExactElements (fixes #771) [878940c]
  • issue_765 - fixed bug in Hopcroft-Karp algorithm [ebadb67]

Maintenance

  • bump ginkgo [8af2ece]
  • Fix typo in docs [123a071]
  • Bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3 (#756) [0e69083]
  • Bump google.golang.org/protobuf from 1.33.0 to 1.34.1 (#755) [2675796]
  • Bump golang.org/x/net from 0.24.0 to 0.25.0 (#754) [4160c0f]
  • Bump github-pages from 230 to 231 in /docs (#748) [892c303]
Commits
  • 32e5498 v1.34.0
  • cb3fa6a run go mod tidy and wonder why go get doesnt just run it for me in the first ...
  • 8af2ece bump ginkgo
  • 878940c fix incorrect handling of nil slices in HaveExactElements (fixes #771)
  • f5bec80 clean up bipartitegraph tests
  • ebadb67 issue_765 - fixed bug in Hopcroft-Karp algorithm
  • 123a071 Fix typo in docs
  • c549e0d Add RoundTripper method to ghttp.Server
  • 0e69083 Bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3 (#756)
  • 2675796 Bump google.golang.org/protobuf from 1.33.0 to 1.34.1 (#755)
  • Additional commits viewable in compare view

Updates sigs.k8s.io/kustomize/api from 0.17.2 to 0.17.3

Release notes

Sourced from sigs.k8s.io/kustomize/api's releases.

api/v0.17.3

chore

#5506: fix some comments #5693: fix: always show accumulation errors #5699: chore: add deprecation comment to commonLabels #5698: fix(namereference): add configuration for new admission API

Dependencies

#5734: Update kyaml to v0.17.2

Commits
  • ddeb572 Merge pull request #5735 from koba1t/pinToCmdConfig
  • 36d78f6 Update cmd/config to v0.14.2
  • 4e52632 Merge pull request #5734 from koba1t/pinToKyaml
  • 8eacab0 Update kyaml to v0.17.2
  • 1a41303 Merge pull request #5628 from antoooks/release-helper-script
  • 7cbaf78 fix:kustomize cfg grep with no arguments causes panic (#5707)
  • 735ad0b Merge pull request #5682 from kozjan/add-label-include-templates
  • c1de030 Merge pull request #5413 from crenshaw-dev/patch-1
  • 5cfd3ab Merge pull request #5725 from kubernetes-sigs/dependabot/go_modules/hack/gola...
  • dfb3064 build(deps): bump golang.org/x/image from 0.13.0 to 0.18.0 in /hack
  • Additional commits viewable in compare view

Updates sigs.k8s.io/kustomize/kyaml from 0.17.1 to 0.17.2

Release notes

Sourced from sigs.k8s.io/kustomize/kyaml's releases.

api/v0.17.2

Feature

#5294: feat: localize absolute paths #5556: feat: support labels key in transformer configuration

Bug fixes/Performance improvements

#5079: perf: improve applyOrdering by avoid call to GetByCurrentId #5500: add testcase that check yield malformed yaml errors

chore

#5625: fix: return error instead of log.Fatalf() #5651: fix: use fmt.Errorf instead of non-existing errors.New

Dependencies

#5672: chore(deps): bump dependencies of kustomize + sync go workspace #5680: chore: restore version for github.com/asaskevich/govalidator #5702: Update kyaml to v0.17.1

kyaml/v0.17.2

chore

#5413: chore(docs): fix grammar error in comment #5506: fix some comments

Commits
  • 9cc25a5 Merge pull request #5703 from koba1t/pinToCmdConfig
  • f6ad718 Update cmd/config to v0.14.1
  • da14e76 Merge pull request #5702 from koba1t/pinToKyaml
  • 7424956 Update kyaml to v0.17.1
  • e244b83 Merge pull request #5688 from emirot/refactor/indexOf
  • f983846 refactor: function in stdlib now
  • 49a645f Merge pull request #5294 from typeid/localize_absolute_paths
  • e7a1549 fix: use fmt.Errorf instead of non-existing errors.New (#5651)
  • 0d7d830 Merge pull request #5681 from emirot/remove-string-in-slice
  • e676d05 Merge pull request #5500 from charles-chenzz/kust-target-tc
  • Additional commits viewable in compare view

Updates github.com/vmware/govmomi from 0.38.0 to 0.39.0

Release notes

Sourced from github.com/vmware/govmomi's releases.

v0.39.0

Release v0.39.0

Release Date: 2024-07-22

🐞 Fix

  • [1bc3a4a4] handle base types by default in mo.LoadObjectContent

💫 API Changes

  • [5c0af375] use CheckTestType in compat and provisioning checkers
  • [2e77836c] add sata controller
  • [bdb034ee] Exporting Unit field in MetricSeries struct for external use (#3494)
  • [78f07c63] Add simulator test for GetVirtualDiskInfoByUUID
  • [2d16e19f] GetVirtualDiskInfoByUUID for getting capacity/size info
  • [29b1bce9] change CoresPerNumaNode to a pointer type
  • [3139de32] Add a method for extending VMDK
  • [6096c0d4] add ResolveLibraryItemStorage

💫 govc (CLI)

  • [04fe4c26] add vm.check commands
  • [976bca3b] add '-spec' flag to vm clone, migrate and create commands
  • [d92015c4] add vm.migrate -net flag

💫 vcsim (Simulator)

  • [eb2e1ea1] add VmCompatibilityChecker and VmProvisioningChecker
  • [a463e543] Add support for DRS automation levels (#3485)
  • [f7a85a81] Re-enable TenantManager

🧹 Chore

  • [590c92b1] Update version.go for v0.39.0
  • [4434e26b] bump go version
  • [d7e27099] fix codeql (#3492) (#3492)
  • [fb6e5977] fix codeql

⚠️ BREAKING

📖 Commits

  • [590c92b1] chore: Update version.go for v0.39.0
  • [5c0af375] api: use CheckTestType in compat and provisioning checkers
  • [2e77836c] api: add sata controller
  • [bdb034ee] api: Exporting Unit field in MetricSeries struct for external use (#3494)
  • [4434e26b] chore: bump go version

... (truncated)

Commits
  • 590c92b chore: Update version.go for v0.39.0
  • 7614742 Merge pull request #3502 from bryanv/bryanv/use-checktesttype-in-check-args
  • f05efc4 Merge pull request #3458 from vmware/api/add-sata-controller
  • 5c0af37 api: use CheckTestType in compat and provisioning checkers
  • 2e77836 api: add sata controller
  • 4ce273c Merge pull request #3500 from dougm/vcsim-vmcheck
  • 441e932 Merge pull request #3497 from aneesurrehman001/feature/export-unit-field
  • bdb034e api: Exporting Unit field in MetricSeries struct for external use
  • 4434e26 chore: bump go version
  • 04fe4c2 govc: add vm.check commands
  • Additional commits viewable in compare view

Updates github.com/onsi/ginkgo/v2 from 2.19.0 to 2.19.1

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.19.1

2.19.1

Fixes

  • update supported platforms for race conditions [63c8c30]
  • [build] Allow custom name for binaries. [ff41e27]

Maintenance

  • bump gomega [76f4e0c]
  • Bump rexml from 3.2.6 to 3.2.8 in /docs (#1417) [b69c00d]
  • Bump golang.org/x/sys from 0.20.0 to 0.21.0 (#1425) [f097741]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.19.1

Fixes

  • update supported platforms for race conditions [63c8c30]
  • [build] Allow custom name for binaries. [ff41e27]

Maintenance

  • bump gomega [76f4e0c]
  • Bump rexml from 3.2.6 to 3.2.8 in /docs (#1417) [b69c00d]
  • Bump golang.org/x/sys from 0.20.0 to 0.21.0 (#1425) [f097741]
Commits

Updates github.com/onsi/gomega from 1.33.1 to 1.34.0

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.34.0

1.34.0

Features

  • Add RoundTripper method to ghttp.Server [c549e0d]

Fixes

  • fix incorrect handling of nil slices in HaveExactElements (fixes #771) [878940c]
  • issue_765 - fixed bug in Hopcroft-Karp algorithm [ebadb67]

Maintenance

  • bump ginkgo [8af2ece]
  • Fix typo in docs [123a071]
  • Bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3 (#756) [0e69083]
  • Bump google.golang.org/protobuf from 1.33.0 to 1.34.1 (#755) [2675796]
  • Bump golang.org/x/net from 0.24.0 to 0.25.0 (#754) [4160c0f]
  • Bump github-pages from 230 to 231 in /docs (#748) [892c303]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.34.0

Features

  • Add RoundTripper method to ghttp.Server [c549e0d]

Fixes

  • fix incorrect handling of nil slices in HaveExactElements (fixes #771) [878940c]
  • issue_765 - fixed bug in Hopcroft-Karp algorithm [ebadb67]

Maintenance

  • bump ginkgo [8af2ece]
  • Fix typo in docs [123a071]
  • Bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3 (#756) [0e69083]
  • Bump google.golang.org/protobuf from 1.33.0 to 1.34.1 (#755) [2675796]
  • Bump golang.org/x/net from 0.24.0 to 0.25.0 (#754) [4160c0f]
  • Bump github-pages from 230 to 231 in /docs (#748) [892c303]
Commits
  • 32e5498 v1.34.0
  • cb3fa6a run go mod tidy and wonder why go get doesnt just run it for me in the first ...
  • 8af2ece bump ginkgo
  • 878940c fix incorrect handling of nil slices in HaveExactElements (fixes #771)
  • f5bec80 clean up bipartitegraph tests
  • ebadb67 issue_765 - fixed bug in Hopcroft-Karp algorithm
  • 123a071 Fix typo in docs
  • c549e0d Add RoundTripper method to ghttp.Server
  • 0e69083 Bump github.com/onsi/ginkgo/v2 from 2.17.2 to 2.17.3 (#756)
  • 2675796 Bump google.golang.org/protobuf from 1.33.0 to 1.34.1 (#755)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

… 5 updates

Bumps the all-go-mod-patch-and-minor group with 3 updates in the / directory: [github.com/vmware/govmomi](https://github.com/vmware/govmomi), [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) and [sigs.k8s.io/kustomize/api](https://github.com/kubernetes-sigs/kustomize).
Bumps the all-go-mod-patch-and-minor group with 2 updates in the /test directory: [github.com/vmware/govmomi](https://github.com/vmware/govmomi) and [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo).


Updates `github.com/vmware/govmomi` from 0.38.0 to 0.39.0
- [Release notes](https://github.com/vmware/govmomi/releases)
- [Changelog](https://github.com/vmware/govmomi/blob/main/CHANGELOG.md)
- [Commits](vmware/govmomi@v0.38.0...v0.39.0)

Updates `github.com/onsi/ginkgo/v2` from 2.19.0 to 2.19.1
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.19.0...v2.19.1)

Updates `github.com/onsi/gomega` from 1.33.1 to 1.34.0
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.33.1...v1.34.0)

Updates `sigs.k8s.io/kustomize/api` from 0.17.2 to 0.17.3
- [Release notes](https://github.com/kubernetes-sigs/kustomize/releases)
- [Commits](kubernetes-sigs/kustomize@api/v0.17.2...api/v0.17.3)

Updates `sigs.k8s.io/kustomize/kyaml` from 0.17.1 to 0.17.2
- [Release notes](https://github.com/kubernetes-sigs/kustomize/releases)
- [Commits](kubernetes-sigs/kustomize@api/v0.17.1...api/v0.17.2)

Updates `github.com/vmware/govmomi` from 0.38.0 to 0.39.0
- [Release notes](https://github.com/vmware/govmomi/releases)
- [Changelog](https://github.com/vmware/govmomi/blob/main/CHANGELOG.md)
- [Commits](vmware/govmomi@v0.38.0...v0.39.0)

Updates `github.com/onsi/ginkgo/v2` from 2.19.0 to 2.19.1
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.19.0...v2.19.1)

Updates `github.com/onsi/gomega` from 1.33.1 to 1.34.0
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.33.1...v1.34.0)

---
updated-dependencies:
- dependency-name: github.com/vmware/govmomi
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: sigs.k8s.io/kustomize/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: sigs.k8s.io/kustomize/kyaml
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: github.com/vmware/govmomi
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jul 29, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2024
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d63e293401b48055b6d32a6cdc2eab3afb14807

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 25174d5 into main Jul 30, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 30, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/all-go-mod-patch-and-minor-89190c53b1 branch July 30, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants